-
Notifications
You must be signed in to change notification settings - Fork 486
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release Notes NuGet 6.2 #2744
Release Notes NuGet 6.2 #2744
Conversation
Docs Build status updates of commit f1c9be1:
|
File | Status | Preview URL | Details |
---|---|---|---|
docs/release-notes/NuGet-6.2.md | View | Details |
docs/release-notes/NuGet-6.2.md
- Line 4, Column 9: [Warning: author-not-found - See documentation]
Invalid value for author: '<GithubAlias>' is not a valid GitHub ID.
- Line 5, Column 12: [Suggestion: ms-author-invalid - See documentation]
Invalid value for 'ms.author', '<MicrosoftAlias>' is not a valid Microsoft alias.
- Line 16, Column 7: [Suggestion: disallowed-html-tag - See documentation]
HTML tag 'NuGetVersion' isn't allowed. Replace it with approved Markdown or escape the brackets if the content is a placeholder.
- Line 16, Column 71: [Suggestion: disallowed-html-tag - See documentation]
HTML tag 'VSYear' isn't allowed. Replace it with approved Markdown or escape the brackets if the content is a placeholder.
- Line 16, Column 88: [Suggestion: disallowed-html-tag - See documentation]
HTML tag 'VSVersion' isn't allowed. Replace it with approved Markdown or escape the brackets if the content is a placeholder.
- Line 16, Column 151: [Suggestion: disallowed-html-tag - See documentation]
HTML tag 'SDKVersion' isn't allowed. Replace it with approved Markdown or escape the brackets if the content is a placeholder.
- Line 18, Column 44: [Suggestion: disallowed-html-tag - See documentation]
HTML tag 'VSYear' isn't allowed. Replace it with approved Markdown or escape the brackets if the content is a placeholder.
For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:
- Try searching the docs.microsoft.com contributor guides
- Post your question in the Docs support channel
I think I'd probably remove the feature prefixes from issues titles. We should also consider not including the sub features of larger feature in the main part. Our tooling/labeling probably needs special considerations :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for getting this going!
A common thing when we use automation is that sometimes the description are not very user friendly. :)
Added some suggestions.
docs/release-notes/NuGet-6.2.md
Outdated
|
||
* Introduce a warning for null/empty version range (new or reuse NU1604) - [#9767](https://github.com/NuGet/Home/issues/9767) | ||
|
||
* NuGet restore in VS should report progress to allow the project-system to better control design time build scheduling. - [#9782](https://github.com/NuGet/Home/issues/9782) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be a feature: NuGet/Home#9782.
We should include in the features with the title Add IVsNuGetProjectUpdateEvents in Visual Studio, reporting of restore changes for PackageReference based projects.
https://docs.microsoft.com/en-us/nuget/visual-studio-extensibility/nuget-api-in-visual-studio#ivsnugetprojectupdateevents-interface
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should the link to the documentation be added in the release notes?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can do it.
Usually we don't have everything document at release, so adding it would be nice I tihnk.
…eature from bugs section
Docs Build status updates of commit 1e5bce8:
|
File | Status | Preview URL | Details |
---|---|---|---|
docs/release-notes/NuGet-6.2.md | View | Details |
docs/release-notes/NuGet-6.2.md
- Line 4, Column 9: [Warning: author-not-found - See documentation]
Invalid value for author: '<GithubAlias>' is not a valid GitHub ID.
- Line 5, Column 12: [Suggestion: ms-author-invalid - See documentation]
Invalid value for 'ms.author', '<MicrosoftAlias>' is not a valid Microsoft alias.
- Line 16, Column 7: [Suggestion: disallowed-html-tag - See documentation]
HTML tag 'NuGetVersion' isn't allowed. Replace it with approved Markdown or escape the brackets if the content is a placeholder.
- Line 16, Column 71: [Suggestion: disallowed-html-tag - See documentation]
HTML tag 'VSYear' isn't allowed. Replace it with approved Markdown or escape the brackets if the content is a placeholder.
- Line 16, Column 88: [Suggestion: disallowed-html-tag - See documentation]
HTML tag 'VSVersion' isn't allowed. Replace it with approved Markdown or escape the brackets if the content is a placeholder.
- Line 16, Column 151: [Suggestion: disallowed-html-tag - See documentation]
HTML tag 'SDKVersion' isn't allowed. Replace it with approved Markdown or escape the brackets if the content is a placeholder.
- Line 18, Column 44: [Suggestion: disallowed-html-tag - See documentation]
HTML tag 'VSYear' isn't allowed. Replace it with approved Markdown or escape the brackets if the content is a placeholder.
For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:
- Try searching the docs.microsoft.com contributor guides
- Post your question in the Docs support channel
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
|
||
<sup>1</sup> Installed with Visual Studio <VSYear> with.NET Core workload | ||
|
||
## Summary: What's New in 6.2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great to me.
Actually maybe we should do a I think I'm supposed to write something for that. I'll try to write up it later today. |
Docs Build status updates of commit 70bf599:
|
File | Status | Preview URL | Details |
---|---|---|---|
docs/release-notes/NuGet-6.2.md | View | Details |
docs/release-notes/NuGet-6.2.md
- Line 30, Column 187: [Warning: hard-coded-locale - See documentation]
Link 'https://docs.microsoft.com/en-us/nuget/visual-studio-extensibility/nuget-api-in-visual-studio#ivsnugetprojectupdateevents-interface' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites.
- Line 30, Column 187: [Suggestion: docs-link-absolute - See documentation]
Absolute link 'https://docs.microsoft.com/en-us/nuget/visual-studio-extensibility/nuget-api-in-visual-studio#ivsnugetprojectupdateevents-interface' will be broken in isolated environments. Replace with a relative link.
For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:
- Try searching the docs.microsoft.com contributor guides
- Post your question in the Docs support channel
Docs Build status updates of commit f17bc41: ✅ Validation status: passed
docs/release-notes/NuGet-6.2.md
For more details, please refer to the build report. Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report. For any questions, please:
|
docs/release-notes/NuGet-6.2.md
Outdated
|
||
* NuGet.exe list from local packages folder does not work with the AllVersion flag - [#4537](https://github.com/NuGet/Home/issues/4537) | ||
|
||
* Project A referencing package B via AssetTargetFallback, doesn't use that same AssetTargetFallback to pull B's dependency package C - [#5957](https://github.com/NuGet/Home/issues/5957) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wrote up a guide for the ATF change, maybe we can link it? NuGet/Samples#53
In particular I want to:
- Get the samples PR reviewed and merged.
- Add a comment linking that here.
cc @JonDouglas
Do you think we should add this to the notable changes list?
Do we want to add a Known issues
section or something like that?
Maybe we have a better that mentions that this issue has consequences.
Open to ideas.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dominoFire suggests that we can add More info
and link to the example, in particular https://github.com/NuGet/Samples/tree/main/AssetTargetFallbackTransitiveDependencies.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pushed this.
Should be complete now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
known issues
best for anything that is known with the release and will addressed soon or has significant limitations when using today.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This one is basically, you might have some weirdness, but there's no proposed changes right now.
See More Information, what we have right now, might work better for that.
Feel free to tweak if you think it's necessary
Docs Build status updates of commit 8a6c550: ✅ Validation status: passed
docs/release-notes/NuGet-6.2.md
For more details, please refer to the build report. Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report. For any questions, please:
|
Docs Build status updates of commit 23647e4: ✅ Validation status: passed
docs/release-notes/NuGet-6.2.md
For more details, please refer to the build report. Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report. For any questions, please:
|
Docs Build status updates of commit 8338693:
|
File | Status | Preview URL | Details |
---|---|---|---|
docs/release-notes/NuGet-6.2.md | View | Details |
docs/release-notes/NuGet-6.2.md
- Line 30, Column 187: [Warning: file-not-found - See documentation]
Invalid file link: '../visual-studio-extensibility/nuget-api-in-visual-studio'.
For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:
- Try searching the docs.microsoft.com contributor guides
- Post your question in the Docs support channel
Docs Build status updates of commit cd87c03: ✅ Validation status: passed
For more details, please refer to the build report. Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report. For any questions, please:
|
Is there something left to do? Can I merge this PR? |
Docs Build status updates of commit fd31628: ✅ Validation status: passed
For more details, please refer to the build report. Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report. For any questions, please:
|
Docs Build status updates of commit 8612961: ✅ Validation status: passed
For more details, please refer to the build report. Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report. For any questions, please:
|
Docs Build status updates of commit b0f597e: ✅ Validation status: passed
For more details, please refer to the build report. Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report. For any questions, please:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do feel free to merge with what we have today. I will likely go back and update feature call outs and such later.
Can we get them merged to live? |
I haven't cleaned the file yet, just created it
NuGet/NuGet.Client@release-6.1.x...release-6.2.x