Small UI fixes #5853
Merged
Small UI fixes #5853
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scottbommarito
requested review from
joelverhagen,
agr,
loic-sharma,
xavierdecoster,
shishirx34,
nugetlurker,
ryuyu,
anangaur,
chenriksson,
cristinamanum and
skofman1
loic-sharma
reviewed
Apr 30, 2018
| string subject = "[{0}] Package uploaded - {1} {2}"; | ||
| string body = @"The package [{1} {2}]({3}) was just uploaded to {0}. If this was not intended, please [contact support]({4}). | ||
| string subject = $"[{Config.GalleryOwner.DisplayName}] Package uploaded - {package.PackageRegistration.Id} {package.Version}"; | ||
| string body = $@"The package [{package.PackageRegistration.Id} {package.Version}]({packageUrl}) was just uploaded to {Config.GalleryOwner.DisplayName} by {package.User.Username}. If this was not intended, please [contact support]({packageSupportUrl}). |
There was a problem hiding this comment.
just [](start = 112, length = 4)
Nit: "was just uploaded" -> "was uploaded" / "was recently uploaded" ?
loic-sharma
reviewed
Apr 30, 2018
| @@ -71,7 +71,7 @@ | |||
| @* Note that we're not confirming that a request even exists for this user, it's just a string compare against the name in the URL *@ | |||
| @ViewHelpers.AlertDanger( | |||
| @<text> | |||
| This request link is for the user '@Model.Username'. If you wish to accept it, | |||
| This request link is for the user '@Model.Username'. If you want to accept it, | |||
There was a problem hiding this comment.
want [](start = 84, length = 4)
Nit: "want" seems a little strong. What do you think of "would like"?
There was a problem hiding this comment.
replaced every "want" with "would like" lol
loic-sharma
reviewed
Apr 30, 2018
| string subject = "[{0}] Package published - {1} {2}"; | ||
| string body = @"The package [{1} {2}]({3}) was just published on {0}. If this was not intended, please [contact support]({4}). | ||
| string subject = $"[{CoreConfiguration.GalleryOwner.DisplayName}] Package published - {package.PackageRegistration.Id} {package.Version}"; | ||
| string body = $@"The package [{package.PackageRegistration.Id} {package.Version}]({packageUrl}) was just published on {CoreConfiguration.GalleryOwner.DisplayName} by {package.User.Username}. If this was not intended, please [contact support]({packageSupportUrl}). |
There was a problem hiding this comment.
just [](start = 112, length = 4)
Same feedback as before here.
loic-sharma
approved these changes
Apr 30, 2018
chenriksson
approved these changes
Apr 30, 2018
added 2 commits
April 30, 2018 13:36
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#5820
#5741
#5746
#5770
#5807
#5817