GA - obfuscate ip and user names #5791
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cristinamanum
requested review from
chenriksson,
scottbommarito,
loic-sharma,
agr,
shishirx34,
joelverhagen,
skofman1 and
ryuyu
shishirx34
approved these changes
Apr 11, 2018
| <script> | ||
| (function(i,s,o,g,r,a,m){i['GoogleAnalyticsObject']=r;i[r]=i[r]||function(){ | ||
| (i[r].q=i[r].q||[]).push(arguments)},i[r].l=1*new Date();a=s.createElement(o), | ||
| m=s.getElementsByTagName(o)[0];a.async=1;a.src=g;m.parentNode.insertBefore(a,m) | ||
| })(window,document,'script','https://www.google-analytics.com/analytics.js','ga'); | ||
|
|
||
| ga('create', '@propertyId', 'auto'); | ||
| ga('set', 'anonymizeIp', true); |
| { | ||
| public static string ObfuscateRequestUrl(HttpContextBase httpContext, RouteCollection routes) | ||
| { | ||
| if (httpContext == null || httpContext.Request == null || httpContext.Request.Url == null || routes == null) |
There was a problem hiding this comment.
Simplify
if (httpContext?.Request?.Url == null || routes == null)
scottbommarito
approved these changes
Apr 11, 2018
| { | ||
| return string.Empty; | ||
| } | ||
| return route.ObfuscateUrlPath(httpContext.Request.Url.AbsolutePath.TrimStart('/')); |
There was a problem hiding this comment.
nit: use tertiary operator to reduce code
var route = routes.GetRouteData(httpContext)?.Route as Route;
return route == null ? string.Empty : route.ObfuscateUrlPath(httpContext.Request.Url.AbsolutePath.TrimStart('/'));
| } | ||
|
|
||
| [Fact] | ||
| public void NullContext() |
There was a problem hiding this comment.
nit: usually test cases have names to describe the expected response in addition to the input
e.g.
WithNullContextReturnsEmptyString
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support to anonymizeIp and obfuscate user names in GA.