[Organizations] Minor bug fixes from dev #5576
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scottbommarito
requested review from
joelverhagen,
agr,
loic-sharma,
xavierdecoster,
shishirx34,
nugetlurker,
ryuyu,
anangaur,
chenriksson,
cristinamanum and
skofman1
chenriksson
approved these changes
Mar 5, 2018
| @@ -29,6 +29,8 @@ public User CurrentUser | |||
| get { return NuGetContext.CurrentUser; } | |||
| } | |||
|
|
|||
| public IContentObjectService ContentObjectService => DependencyResolver.Current.GetService<IContentObjectService>(); | |||
joelverhagen
reviewed
Mar 5, 2018
| .FirstOrDefault(u => | ||
| u.Username.Equals(username, StringComparison.OrdinalIgnoreCase) || | ||
| string.Equals(u.EmailAddress, emailAddress, StringComparison.OrdinalIgnoreCase)); | ||
| .FirstOrDefault(u => u.Username == username || u.EmailAddress == emailAddress); |
There was a problem hiding this comment.
Yeah this is already case-insensitive thanks to our DB collation.
There was a problem hiding this comment.
Yup, was 500'ing before with the string.Equals
joelverhagen
approved these changes
Mar 5, 2018
shishirx34
approved these changes
Mar 5, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1 - Fetch the image immediately for the text box on the add page if the form is already filled (e.g. if form submission fails, show the image from the email already.
2 - Don't use
string.Equalsin EF queryables because it throws on Azure SQL lol.3 - Show the
Manage Organizationspage for users who are allowed to create an org.