Enable reflowing of packages that don't pass the valid version range rule #5524
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joelverhagen
requested review from
agr,
loic-sharma,
xavierdecoster,
shishirx34,
ryuyu,
chenriksson,
cristinamanum,
skofman1 and
scottbommarito
|
🔔 |
shishirx34
approved these changes
Feb 23, 2018
| /// <exception cref="PackagingException"> | ||
| /// We default to use a strict version-check on dependency groups. | ||
| /// When an invalid dependency version range is detected, a <see cref="PackagingException"/> will be thrown. | ||
| /// </exception> | ||
| public static PackageMetadata FromNuspecReader(NuspecReader nuspecReader) | ||
| public static PackageMetadata FromNuspecReader(NuspecReader nuspecReader, bool strict) |
There was a problem hiding this comment.
nit: may be rename this parameter to dependencyVersionStrictCheck to better reflect the change?
There was a problem hiding this comment.
I was hoping to leave it as script so that future validations can be relaxed with this same parameter.
joelverhagen
force-pushed
the
jver-relax-reflow
branch
from
008cd75 to
433de7c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #5522