[BugBash] Prevent added model errors from being reset by JQuery Validate #5502
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scottbommarito
requested review from
joelverhagen,
agr,
loic-sharma,
xavierdecoster,
shishirx34,
nugetlurker,
ryuyu,
anangaur,
chenriksson,
cristinamanum and
skofman1
chenriksson
approved these changes
Feb 16, 2018
| @@ -45,6 +45,9 @@ | |||
| @Html.ShowTextBoxFor(m => m.AdminUsername) | |||
| @Html.ShowValidationMessagesFor(m => m.AdminUsername) | |||
There was a problem hiding this comment.
Since we're using string.Empty, should we remove ShowValidationMessagesFor(m => m.AdminUsername), Email, etc?
There was a problem hiding this comment.
No, because those will show errors with AdminUsername not specified by us (e..g. if the field is empty).
joelverhagen
approved these changes
Feb 22, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#5454
Basically, by putting the errors on
string.Emptyinstead ofAdminUsername, they are not erased by JQuery Validate when it checks the input.Also fixed this in the
ForgotPasswordform because it was easy to do so.