Cache admins and collaborators for permissions #5472
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chenriksson
requested review from
joelverhagen,
agr,
loic-sharma,
shishirx34,
ryuyu,
cristinamanum,
skofman1,
scottbommarito and
xavierdecoster
skofman1
reviewed
Feb 13, 2018
| @@ -109,7 +109,7 @@ public class UserService : IUserService | |||
| if (membership.IsAdmin != isAdmin) | |||
| { | |||
| // block removal of last admin | |||
| if (membership.IsAdmin && organization.Members.Count(m => m.IsAdmin) == 1) | |||
| if (membership.IsAdmin && organization.Administrators.Count() == 1) | |||
There was a problem hiding this comment.
rganization.Administrators.Count() == 1 [](start = 43, length = 39)
nit: use Any()
There was a problem hiding this comment.
The check is to see if the last admin is being removed, so I need to check for exactly 1 not >= 1
scottbommarito
approved these changes
Feb 14, 2018
chenriksson
force-pushed
the
chenriks-perf-managepackages
branch
2 times, most recently
from
5b0bacd to
0f557ab
Compare
chenriksson
force-pushed
the
chenriks-perf-managepackages2
branch
from
4888c2c to
a8a7e4b
Compare
chenriksson
added a commit
that referenced
this pull request
Feb 15, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #5461, optimization 2.
Caches and separates admin/collaborators lookups for current user during permissions checks so duplicate checks don't hit the DB.
Originally saw response go from 37.8s -> 35.1s, but now seeing it go from 59.1s -> 42.5s