SendValidationTakingTooLongNotice method with tests #5402
Conversation
agr
requested review from
joelverhagen,
loic-sharma,
xavierdecoster,
shishirx34,
ryuyu,
chenriksson,
cristinamanum,
skofman1,
karann-msft and
scottbommarito
|
@agr what is "too much time"? where is that defined and how easy is to modify that? |
|
@karann-msft, it's what previously was "failure timeout" in the orchestrator configuration file: Another PR is coming with Orchestrator changes once this one is merged. |
|
@karann-msft modification would consist of configuration update and service redeployment. |
|
@agr, what will be this value configured to? 1 hour? 24 hours? |
|
Right now it "inherited" the previous "failAfter" value of 1 day, reducing it seems like a right thing. Would need to update our alerting, too, once we settle on a value. |
| string body = "It is taking longer than expected for your package [{1} {2}]({3}) to get published.\n\n" + | ||
| "We are looking into it and there is no action on you at this time. We’ll send you an email notification when your package has been published.\n\n" + | ||
| "Thank you for your patience.\n\n" + | ||
| "NuGet Team"; |
There was a problem hiding this comment.
Should we use something like GalleryOwner, instead of NuGet Team?
There was a problem hiding this comment.
You are right. Good catch!
There was a problem hiding this comment.
Removed the signature completely as we don't have it in other emails.
|
We already have an alert |
Removed the unused argument from the `SendValidationTakingTooLongNotice` method
Added a method to
CoreMessageServicethat sends notification about validation taking too much time.Part of the changes for the https://github.com/NuGet/Engineering/issues/1144