Fix issue: [DEV] Images missing from Dev environment #5280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cristinamanum
requested review from
chenriksson,
shishirx34,
skofman1,
joelverhagen,
scottbommarito,
agr,
loic-sharma and
ryuyu
joelverhagen
approved these changes
Jan 17, 2018
chenriksson
reviewed
Jan 17, 2018
| return RouteTable.Routes.GetRouteData(new HttpContextWrapper(HttpContext.Current)).Route as Route; | ||
| if (HttpContext.Current == null) | ||
| { | ||
| return null; |
There was a problem hiding this comment.
ModifyItem returns w/o obfuscation when GetCurrentRoute returns null. Is this ok? Is HttpContext.Current always available for urls we need to obfuscate?
There was a problem hiding this comment.
The HttpContext should always be available. From the current data it is ok to not obfuscate if the route is null.
chenriksson
approved these changes
Jan 17, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to null ref exception in ClientTelemetryPIIProcessor.