[Organizations] Merge permissions service 2.0 feature branch into dev #5229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scottbommarito
requested review from
agr,
loic-sharma,
xavierdecoster,
shishirx34,
nugetlurker,
ryuyu,
chenriksson,
cristinamanum and
skofman1
scottbommarito
force-pushed
the
sb-feature-orgpermissions
branch
from
3411a0a to
b6ba3fa
Compare
chenriksson
approved these changes
Jan 4, 2018
| @@ -299,27 +299,21 @@ public virtual JsonResult UploadPackageProgress() | |||
| var id = nuspec.GetId(); | |||
| var packageRegistration = _packageService.FindPackageRegistrationById(id); | |||
| // For a new package id verify if the user is allowed to use it. | |||
| if (packageRegistration == null) | |||
| if (packageRegistration == null && ActionsRequiringPermissions.UploadNewPackageId.CheckPermissionsOnBehalfOfAnyAccount(currentUser, new ActionOnNewPackageContext(id, _reservedNamespaceService)) != PermissionsCheckResult.Allowed) | |||
added 9 commits
January 8, 2018 10:48
…enseReportVisibility (UI) (#5151)
scottbommarito
force-pushed
the
sb-feature-orgpermissions
branch
from
b6ba3fa to
0824e07
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR brings the fixes and testing implemented in the permissions service 2.0 feature branch into dev.