Add link to package in Contact Owners email #5202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scottbommarito
requested review from
joelverhagen,
agr,
loic-sharma,
xavierdecoster,
shishirx34,
nugetlurker,
ryuyu,
chenriksson,
cristinamanum and
skofman1
chenriksson
approved these changes
Dec 18, 2017
| @@ -208,7 +208,7 @@ public void WillCopySenderIfAsked() | |||
| }; | |||
| var messageService = TestableMessageService.Create(GetConfigurationService()); | |||
|
|
|||
| messageService.SendContactOwnersMessage(from, package, "Test message", "http://someurl/", true); | |||
| messageService.SendContactOwnersMessage(from, package, "http://someurl/", "Test message", "http://someotherurl/", true); | |||
There was a problem hiding this comment.
Maybe distinguish the urls, like http://package-url/ and http://email-settings-url?
Should we have test to validate correct package url included?
shishirx34
approved these changes
Dec 19, 2017
| @@ -129,17 +129,17 @@ public void ReportMyPackage(ReportPackageRequest request) | |||
| } | |||
| } | |||
|
|
|||
| public void SendContactOwnersMessage(MailAddress fromAddress, PackageRegistration packageRegistration, string message, string emailSettingsUrl, bool copySender) | |||
| public void SendContactOwnersMessage(MailAddress fromAddress, PackageRegistration packageRegistration, string packageUrl, string message, string emailSettingsUrl, bool copySender) | |||
There was a problem hiding this comment.
nit: may be format the parameters on new line?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#5087