Issue 4258 - ContactOwners e-mails contain the package version numer next to package id #5116
Conversation
|
|
||
| if (package == null || package.PackageRegistration == null) | ||
| var package = _packageService.FindPackageByIdAndVersionStrict(id, version); | ||
| if (package == null) |
There was a problem hiding this comment.
Any reason why you removed the package.PackageRegistration check?
It's probably redundant, but we do access package.PackageRegistration.Owners directly below, so if package.PackageRegistration is null, this will throw.
| { | ||
| string subject = "[{0}] Message for owners of the package '{1}'"; | ||
| string body = @"_User {0} <{1}> sends the following message to the owners of Package '{2}'._ | ||
| string body = @"_User {0} <{1}> sends the following message to the owners of Package '{2}' {3}._ |
There was a problem hiding this comment.
Package shouldn't be capitalized. Also, it's a little weird to have the ID in quotes but the version not.
E.g.
Package 'Newtonsoft.Json' 6.0.3
I would suggest wrapping the entire thing in quotes.
...sends the following message to the owners of package '{2} {3}'.
| }; | ||
|
|
||
| var packageService = new Mock<IPackageService>(); | ||
| packageService.Setup(p => p.FindPackageByIdAndVersion("pkgid", null, null, true)).Returns(package); | ||
| packageService.Setup(p => p.FindPackageByIdAndVersionStrict("pkgid", "1.0.0")).Returns(package); |
There was a problem hiding this comment.
I would suggest saving pkgid and 1.0.0 in variables so you don't need to declare them by hand every time you use them.
var id = "pkgid";
var version = "1.0.0";
...
packageService.Setup(p => p.FindPackageByIdAndVersionStrict(id, version)).Returns(package);
same with the tests below
There was a problem hiding this comment.
fixed & some new tests
ghost
removed
the
|
Hello! |
|
Thanks for the PR @dvkudr ! We will merge this PR and deploy to nuget.org this sprint (the next 3 weeks). |
|
@dvkudr , sorry for taking so long to take care of this. I've just merged this PR and it'll appear in our next deployment. Thanks again for the contribution! |
|
Great! Thank you guys! |
No description provided.