Get rid of obsolete notifications on package details view

[xavierdecoster]

Fixes #4788 (see issue for details)

[joelverhagen]

I see your comment to @anangaur, but it seems weird to leave the "edit failed" message if we are removing the "pending edit". I think we should remove both at the same time, but your call!

[joelverhagen]

Consider marking this as [Obselete] instead of removing it.

[xavierdecoster]

That's an option too. Is this used elsewhere? And if it is, shouldn't we break upon upgrading the consumed NuGetGallery.Core dependency to bring it under our attention (not sure an Obsolete warning message is intrusive enough :)).

[joelverhagen]

I am more thinking that since it's a serialized enum, it will allow us to deserialize the audit later.

[xavierdecoster]

Gotcha. Marked as obsolete in 26074f4

[xavierdecoster]

@joelverhagen the thing is that edits may still be pending at the time of deployment, so we may need to remove this particular Edit-Failed notification in a second deployment?

[joelverhagen]

@joelverhagen the thing is that edits may still be pending at the time of deployment, so we may need to remove this particular Edit-Failed notification in a second deployment?

Seems fine. I think failed edits are a very rare occurrence.