Add support for third-party tabs on package details page #4605
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loic-sharma
requested review from
joelverhagen,
agr,
shishirx34,
ryuyu,
anangaur and
scottbommarito
joelverhagen
requested changes
Sep 1, 2017
There was a problem hiding this comment.
Spoke to @loic-sharma offline. Had a couple comment to ease community contributions in this area.
⌚️
joelverhagen
approved these changes
Sep 1, 2017
shishirx34
approved these changes
Sep 1, 2017
|
There was an alternative wording suggested in the issue, did you consider using it instead?.. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4589. Note that this doesn't actually add any third-party tabs, it simply adds the necessary styling to support third-party tabs. This gist shows the necessary changes needed to add Paket.