First ResolveUri in NuGet.Services.Storage #10129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the following jobs on the new storage SDK.
ResolveUriwas not working since the container URL lost it's trailing/, leading tonew Uri(base, blob)behavior changing. The cursor URL was resolving to the root of the blob storage account, not in the storage container.GitHubVulnerabilities2DbandGitHubVulnernabilities2v3were impacted.Summary of changes:
Storage.ResolveUrito be tolerant of trailing and leading/. This fixes the GitHubVulnerabilities job cursors.DateTimeOffset.MinValuecomparison.DateTimeOffset.MinValue == DateTime.MinValue(our VMs). Locally this is not true. This makes local debugging harder. I think this was left over from aDateTimetoDateTimeOffsetrefactoring that was uncaught cause it works on VM.