Add a Python module for log version parsing #10107
Conversation
| { | ||
| "files.autoSave": "onFocusChange", | ||
| "python.testing.unittestArgs": [ | ||
| "-v", |
There was a problem hiding this comment.
Nit: It looks there's extra tab space here
|
We should have a step (perhaps opt in) to |
|
I think this is a good size, roughly for the first PR. If much more functionality is needed it might be better as a 2nd PR. |
|
|
Agreed, though for timing, we'll come back to that later. |
| @@ -382,7 +382,7 @@ FodyWeavers.xsd | |||
| !.vscode/tasks.json | |||
| !.vscode/launch.json | |||
| !.vscode/extensions.json | |||
| *.code-workspace | |||
| !.vscode/*.code-snippets | |||
There was a problem hiding this comment.
nit: could we add this below the "repository specific" cut line so it's easier to pull in newer .gitignore?
There was a problem hiding this comment.
I think this should be in all of our gitignores
There was a problem hiding this comment.
Yes, but it could be below the # Repository specific # line to clearly show what came from https://github.com/github/gitignore/blob/main/VisualStudio.gitignore and what was added by us
| ("microsoft.applicationinsights.dependencycollector", "2.4.1", "http://localhost/packages/microsoft.applicationinsights.dependencycollector%20.2.4.1.nupkg"), | ||
| ("microsoft.applicationinsights.dependencycollector", "2.4.1", "http://localhost/packages/microsoft.applicationinsights.dependencycollector%20.2.4.1.nupkg?packageVersion=2.4.1"), | ||
| ("xunit", "2.4.0-beta.1.build3958", "http://localhost/packages/xunit.2.4.0-beta.1.build3958.nupkg"), | ||
| ("xunit.1", "2.4.1-beta.1.build3958", "http://localhost/packages/xunit.1.2.4.1-beta.1.build3958.nupkg?packageVersion=2.4.1-beta.1.build3958"), |
There was a problem hiding this comment.
Can you include 2.1.0-beta1-build2945 test? It has - 2 times.
There was a problem hiding this comment.
Done, with tests passing
A building block for https://github.com/NuGet/Engineering/issues/5082