MSI auth support for NuGetGallery #10059
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like some conflicts, otherwise looks good to me. |
|
@lyndaidaii resolved conflicts. |
dannyjdev
reviewed
Jul 9, 2024
drewgillies
approved these changes
Jul 10, 2024
|
Discussed offline. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Progress on https://github.com/NuGet/Engineering/issues/5335.
Added configuration options for authenticating with MSI for Gallery. Using storage account keys or SAS tokens for authentication still works.
Debug builds when
AzureStorageUseMsi == trueuseDefaultAzureCredentialinstead to support local debugging.Removed the reference to
WindowsAzure.Storagepackage. Cleaned up tests.Added blob properties extraction from
BlobDownloadDetails, so callingOpenReadAsyncwould have blob properties prepared for consumption.