Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NuGet.org Bug]: HTTP responses aren't reported to user #9336

Closed
RussKie opened this issue Dec 25, 2022 · 2 comments
Closed

[NuGet.org Bug]: HTTP responses aren't reported to user #9336

RussKie opened this issue Dec 25, 2022 · 2 comments

Comments

@RussKie
Copy link

RussKie commented Dec 25, 2022

Impact

I'm unable to use NuGet.org

Describe the bug

If a package author tries to upload
a) a signed package without a registered signing key, or
b) an unsigned package when a signing key is registered,
...the package will not be uploaded and no error message will be shown to the author.

The only way to find any kind of information is to open the DevTools and inspect the HTTP response. The HTTP response will look something like

image

Repro Steps

See above

Expected Behavior

The error message is shown to the user, and it clearly explains what the author must do in order to upload the package. The error message in the HTTP response is not be sufficient.
Links to documentation that articulates the necessity would also be helpful.

A slight necessary OT: our organisation maintains several packages some of which are signed and some of which aren't. We can't sign all of the packages (and it's besides the point). Up until recently we published all packages without issues, and now when I tried to upload a new version of the signed package I couldn't do it. After some head scratching and investigations, essentially I was forced to register the signing key. And after that I could no longer upload a new version of the unsigned package....
If this is now "by design" this has to be explained, as well as steps to resolve such situations should be provided. "Sign all your packages" may not be an option.

Screenshots

No response

Additional Context and logs

No response

@joelverhagen
Copy link
Member

It turns out they are reported to the user, but they are hidden behind the newly collapsed "Upload" section heading:
image

I think the fix here is to move errors outside of the section. I'll work on that.

@joelverhagen
Copy link
Member

This is fixed in PROD.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants