Add link to Package Authoring best practices to Package Upload page

[skofman1]

Is your feature request related to a problem? Please describe.

It will make the page more discoverable to package authors.

Describe the solution you'd like

Add a link to this page: https://docs.microsoft.com/en-us/nuget/create-packages/package-authoring-best-practices

//cc @jcjiang

[jcjiang]

Looking at the existing functionality, I feel the warning that pops up when a package does not have sufficient information is a good place to put the link. Maybe it can replace the existing link. I am wary of putting the link at the very top because it is less discoverable. What do people think?

[skofman1]

I thinking changing the 'read more' link is a good idea, but the thing is, that the logic that pops-up this warning doesn't verify all the best practices in the doc.
What do you think about change the 'Read More' but also updating the text in the tab. We can add something like: "To learn how to author great packages read here".

[jcjiang]

Great point. I think linking in both places is a great idea! So something like: # Tab: Your package file will be uploaded and hosted... To learn more about authoring great packages, read here. # Read More We recommend that you fix these issues and upload a new package. For resources on how to do that, read here.

…

On Fri, Feb 12, 2021 at 10:53 AM Svetlana Kofman ***@***.***> wrote: I thinking changing the 'read more' link is a good idea, but the thing is, that the logic that pops-up this warning doesn't verify all the best practices in the doc. What do you think about change the 'Read More' but also updating the text in the tab. We can add something like: "To learn how to author great packages read here". [image: image] <https://user-images.githubusercontent.com/16807822/107809641-45a8bf00-6d20-11eb-904a-17862a658a71.png> — You are receiving this because you were assigned. Reply to this email directly, view it on GitHub <#8411 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AFRYE23J5SGWUWCZLNPCZ3TS6V2JNANCNFSM4XBOZDAA> .

[loic-sharma]

Here are some links to the relevant code:

NuGetGallery/src/NuGetGallery/Views/Packages/UploadPackage.cshtml

Line 20 in c71e124

<p class="message">Your package file will be uploaded and hosted on the @(Config.Current.Brand) server (@(Config.Current.SiteRoot)).</p>

And:

NuGetGallery/src/NuGetGallery/Views/Packages/_VerifyMetadata.cshtml

Lines 77 to 78 in db62de4

	We recommend that you fix these issues and upload a new package.
	<a href="https://docs.microsoft.com/en-us/nuget/policies/nuget-faq#managing-packages-on-nugetorg" alt="Read more" aria-label="Read more about managing packages on nuget.org">Read more</a><br />