Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug workaround: Copy nupkg to stream before Azure upload #24

Merged
merged 1 commit into from
Mar 30, 2016

Conversation

skofman1
Copy link
Contributor

@skofman1 skofman1 self-assigned this Mar 29, 2016
@skofman1 skofman1 added the bug label Mar 29, 2016
@skofman1 skofman1 added this to the 0.1 milestone Mar 29, 2016
@maartenba
Copy link

One remark/thought: what if someone uploads a 60 MB package, then we load that 60 MB package in memory?

Otherwise LGTM :shipit:

@skofman1 skofman1 merged commit 6fe0c90 into dev Mar 30, 2016
@skofman1
Copy link
Contributor Author

I know it's not ideal.. if they don't fix it properly before the feature reaches maturity, we can invest in a better workaround

@skofman1 skofman1 deleted the bug/UploadPackage branch April 1, 2016 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants