Fix ability for individual projects to enable or disable Central Package Management #5866
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug
Fixes: NuGet/Home#13560
Regression? Last working version:
Description
Pull request #5572 enabled or disabled Central Package Management (CPM) if a file named
Directory.Packages.props
exists. It also changed whenDirectory.Packages.props
was imported. Before,Directory.Packages.props
was always imported, whether CPM was enabled or not. in #5572 this changed to only importDirectory.Packages.props
was imported. This breaks users who:Directory.Build.props
This is because
Directory.Packages.props
isn't imported anymore and its impossible for a project to enable it.This change brings back the old behavior of always importing
Directory.Packages.props
even if CPM is disabled. TheManagePackageVersionsCentrally
property still controls whether or not CPM itself is enabled, allowing users to enable CPM for any particular project. In the case where a users wants to disable the import ofDirectory.Packages.props
, they can still set the MSBuild propertyImportDirectoryPackagesProps
to false.PR Checklist
PR has a meaningful title
PR has a linked issue.
Described changes
Tests
Documentation