Output a more debuggable message if a single value isn't specified #5533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
nkolev92
reviewed
Dec 7, 2023
There was a problem hiding this comment.
The change looks great!
A few things:
- Can you please create an issue for this?
- Can youn please add some tests: https://github.com/NuGet/NuGet.Client/blob/dev/test/NuGet.Clients.Tests/NuGet.SolutionRestoreManager.Test/VsSolutionRestoreServiceTests.cs has integration tests, but this is something that should be easily unit testable.
src/NuGet.Clients/NuGet.SolutionRestoreManager/VSNominationUtilities.cs
Outdated
Show resolved
Hide resolved
|
@nkolev92: looking to see if there was an existing bug, I see NuGet/Home#8749 looks somewhat related -- want to call this as fixing that or have me file a new bug? |
Nice catch, that's perfect. |
A number of places call GetSingleNonEvaluatedPropertyOrNull to get the single value that spans all TFMs -- if that's not distinct though the failure that would bubble up to the user wouldn't point to the underlying issue. This makes the failure easier. Fixes NuGet/Home#8749
jasonmalinowski
force-pushed
the
add-better-logging-for-properties
branch
from
4a1eb15 to
b0a0ec8
Compare
|
@nkolev92 Exception message is now localized, and tests added. I broke out a test refactoring into a prior commit so it's a touch easier to review. |
nkolev92
approved these changes
Dec 8, 2023
zivkan
approved these changes
Dec 12, 2023
jeffkl
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A number of places call GetSingleNonEvaluatedPropertyOrNull to get the single value that spans all TFMs -- if that's not distinct though the failure that would bubble up to the user wouldn't point to the underlying issue. This makes the failure easier.
Bug
Fixes: NuGet/Home#8749
Regression? No.
Description
This adds a better exception message than simply calling SingleOrDefault(). The test changes mostly involve extracting out a helper function for other tests doing the same thing.
PR Checklist
PR has a meaningful title
PR has a linked issue.
Described changes
Tests
Documentation