Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optout http warnings by setting allowInsecureConnections in settings #5411

Merged
merged 6 commits into from
Sep 12, 2023

Conversation

heng-liu
Copy link
Contributor

@heng-liu heng-liu commented Sep 12, 2023

Bug

Fixes: NuGet/Home#12785

Regression? Last working version:

Description

Provide a way to opt-out of http warnings, by setting allowInsecureConnections to true in NuGet.Config.
Spec: https://github.com/NuGet/Home/blob/dev/proposed/2023/InsecureConnectionsDisableCertificateValidation.md

This PR combines all sub-PRs which are already reviewed. (You may find the list of sub issues in NuGet/Home#12785)

PR Checklist

@heng-liu heng-liu marked this pull request as ready for review September 12, 2023 16:35
@heng-liu heng-liu requested a review from a team as a code owner September 12, 2023 16:35
Copy link
Contributor

@JonDouglas JonDouglas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@heng-liu heng-liu marked this pull request as draft September 12, 2023 20:05
@heng-liu heng-liu marked this pull request as ready for review September 12, 2023 20:05
@heng-liu heng-liu closed this Sep 12, 2023
@heng-liu heng-liu reopened this Sep 12, 2023
@heng-liu heng-liu merged commit 15389cd into dev Sep 12, 2023
@heng-liu heng-liu deleted the dev-feature-optoutHttpWarnings branch September 12, 2023 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Opt-out of "HTTPs everywhere" by setting allowInsecureConnections to true
3 participants