Fix include flags calculation for transitively pinned centrally managed dependencies #4950
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
|
Next one is #4952 |
8 tasks
jeffkl
previously approved these changes
Nov 29, 2022
nkolev92
previously approved these changes
Nov 30, 2022
marcin-krystianc
dismissed stale reviews from nkolev92 and jeffkl
via
2f09ddd
marcin-krystianc
requested review from
nkolev92 and
jeffkl
and removed request for
nkolev92
nkolev92
approved these changes
Nov 30, 2022
jeffkl
approved these changes
Nov 30, 2022
|
I just requeued the failing Apex test job on CI pipeline. |
erdembayar
approved these changes
Dec 6, 2022
marcin-krystianc
deleted the
marcink-20221124-FlattenDependencyTypesUnified
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug
Fixes: NuGet/Home#12274
Regression? Last working version: no
Description
When the include flags are calculated, only real (
LibraryDependencyReferenceType.Direct) dependencies should be followed. The graph flattening algorithm should skip helper references (LibraryDependencyReferenceType.NoneandLibraryDependencyReferenceType.Transitive).PR Checklist
PR has a meaningful title
PR has a linked issue.
Described changes
Tests
Documentation