refactor NuGet migrations code #4875
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephentoub
reviewed
Oct 25, 2022
nkolev92
previously approved these changes
Oct 25, 2022
stephentoub
reviewed
Oct 25, 2022
stephentoub
approved these changes
Oct 25, 2022
stephentoub
previously approved these changes
Oct 25, 2022
kartheekp-ms
dismissed stale reviews from stephentoub and nkolev92
via
e34e0ce
kartheekp-ms
force-pushed
the
dev-kartheekp-ms-migrationfw
branch
from
e34e0ce
to
ed1429e
Compare
nkolev92
approved these changes
Oct 26, 2022
kartheekp-ms
added a commit
that referenced
this pull request
Nov 3, 2022
kartheekp-ms
added a commit
that referenced
this pull request
Nov 3, 2022
kartheekp-ms
added a commit
that referenced
this pull request
Nov 3, 2022
kartheekp-ms
added a commit
that referenced
this pull request
Nov 3, 2022
kartheekp-ms
added a commit
that referenced
this pull request
Nov 3, 2022
kartheekp-ms
added a commit
that referenced
this pull request
Nov 3, 2022
kartheekp-ms
added a commit
that referenced
this pull request
Nov 3, 2022
kartheekp-ms
added a commit
that referenced
this pull request
Nov 3, 2022
kartheekp-ms
added a commit
that referenced
this pull request
Dec 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug
Fixes: https://github.com/NuGet/Client.Engineering/issues/1936
Regression? Last working version:
Description
Thanks to @stephentoub for taking the time to review #4859 PR offline. I have refactored the code based on the feedback received. At a high level here are the changes proposed in this PR.
Mutex.ReleaseMutex();in thefinally blockjust to be on the safe side.PR Checklist
PR has a meaningful title
PR has a linked issue.
Described changes
Tests
Documentation