Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor CentralPackageManagementFile #4708

Merged
merged 1 commit into from
Jul 1, 2022

Conversation

jeffkl
Copy link
Contributor

@jeffkl jeffkl commented Jul 1, 2022

Bug

Fixes: https://github.com/NuGet/Client.Engineering/issues/1718

Regression? Last working version:

Description

Unify set/add operations, add xml doc comments, and changed how the file is written.

This change will be used by #4680 and #4700

PR Checklist

  • PR has a meaningful title

  • PR has a linked issue.

  • Described changes

  • Tests

    • Automated tests added
    • OR
    • Test exception
    • OR
    • N/A
  • Documentation

    • Documentation PR or issue filled
    • OR
    • N/A

@jeffkl jeffkl requested a review from a team as a code owner July 1, 2022 18:29
@jeffkl jeffkl requested review from kartheekp-ms and pragnya17 July 1, 2022 18:29
@jeffkl jeffkl merged commit da92c9b into dev Jul 1, 2022
@jeffkl jeffkl deleted the dev-jeffkl-refactor-centralpackagemanagementfile branch July 1, 2022 23:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants