Detect sandboxed assembly load in NuGet, warn about required action #4461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erdembayar
force-pushed
the
dev-eryondon-9954-nuget-metadata-unblock
branch
from
5a96d6b to
5702e8f
Compare
erdembayar
commented
Feb 15, 2022
erdembayar
commented
Feb 15, 2022
| @@ -5433,4 +5433,7 @@ Please consider migrating '{0}' to `PackageReference` and using the pack targets | |||
| You can set the '{1}' environment variable to 'true' to temporarily reenable this functionality.</value> | |||
| <comment>Please do not localize `project.json` pack and `PackageReference`. 0 - path, 1 - env var name</comment> | |||
| </data> | |||
| <data name="Error_NuGetExeNeedsToBeUnblockedAfterDownloading" xml:space="preserve"> | |||
| <value>NuGet.exe file on path {0} needs to be unblocked after downloading : {1}</value> | |||
There was a problem hiding this comment.
@JonDouglas @NuGet/nuget-client
Currently path to nuget.exe included 2 times, most likely we just need one, but couldn't decide which one to keep. Please advise.
There was a problem hiding this comment.
The path should be the executing .exe path. I can't honestly tell from this screenshot. They look the same just that the C:\ path is the more empowering one for the user.
There was a problem hiding this comment.
Extra info is:
Not sure if users care about it.
There was a problem hiding this comment.
I removed extra part now it looks like below:
erdembayar
changed the title
erdembayar
changed the title
nkolev92
reviewed
Feb 16, 2022
erdembayar
force-pushed
the
dev-eryondon-9954-nuget-metadata-unblock
branch
2 times, most recently
from
f5702fb to
a39b418
Compare
nkolev92
approved these changes
Feb 17, 2022
erdembayar
force-pushed
the
dev-eryondon-9954-nuget-metadata-unblock
branch
from
3301e43 to
b4281bd
Compare
|
@NuGet/nuget-client |
jeffkl
reviewed
Feb 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug
Fixes: NuGet/Home#9954
Regression? Last working version:
Description
Net framework sandboxing causing hard to reason error for nuget.exe downloaded from internet on Windows OS. Now error is very explicit and clear, added exception handler and new NU5133 error to inform customer about need to unblock nuget.exe.
Adding unit test little bit complicated so I didn't do it, but manually tested it.
Test nuget.exe can be found here, please note it's not MS authenticode signed so ask additional permission when download.
Before:
After:
Before:
After:
Error message can be improved, please give your feedback.
PR Checklist
PR has a meaningful title
PR has a linked issue.
Described changes
Tests
Documentation