Handle no nomination info in VS GetInstalledPackagesAsync API #3959
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erdembayar
reviewed
Mar 23, 2021
There was a problem hiding this comment.
@zivkan
Looks good. Only 2 questions about how nomination works?
...ients.Tests/NuGet.VisualStudio.Implementation.Test/Extensibility/NuGetProjectServiceTests.cs
Show resolved
Hide resolved
...t.Clients.Tests/NuGet.PackageManagement.VisualStudio.Test/CpsPackageReferenceProjectTests.cs
Show resolved
Hide resolved
nkolev92
approved these changes
Mar 23, 2021
...t.Clients.Tests/NuGet.PackageManagement.VisualStudio.Test/CpsPackageReferenceProjectTests.cs
Show resolved
Hide resolved
erdembayar
approved these changes
Mar 23, 2021
src/NuGet.Clients/NuGet.VisualStudio.Implementation/Extensibility/NuGetProjectService.cs
Show resolved
Hide resolved
src/NuGet.Clients/NuGet.VisualStudio.Implementation/Extensibility/NuGetProjectService.cs
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug
Fixes: NuGet/Home#10681
Regression? Last working version: new API in VS 16.8
Description
Make
CpsPackageReferenceProjectthrow a newProjectNotNominatedException, rather than the genericInvalidOperationException, and catch it inGetInstalledPackagesAsync's implementation.PR Checklist
PR has a meaningful title
PR has a linked issue.
Described changes
Tests
Documentation