Validate Newtonsoft.Json version matches VS/.NET Core SDK version #2880
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zivkan
requested review from
dominoFire,
nkolev92,
dtivel,
heng-liu and
donnie-msft
zivkan
force-pushed
the
dev-zivkan-ValidateNewtonsoftJsonVersion
branch
3 times, most recently
from
188d8e0
to
2add553
Compare
dominoFire
reviewed
Jun 10, 2019
nkolev92
reviewed
Jun 11, 2019
test/TestExtensions/TestablePluginCredentialProvider/TestableCredentialProvider.csproj
Outdated
Show resolved
Hide resolved
nkolev92
reviewed
Jun 11, 2019
|
I think only 2 or 3 projects needed the reference to change the version of Newtonsoft.Json. All the others were only to stop the NU1605 warnings that are promoted to errors and therefore break the build. I didn't want to supress all NU1605 warnings, only for Newtonsoft.Json. |
nkolev92
approved these changes
Jun 11, 2019
zivkan
force-pushed
the
dev-zivkan-ValidateNewtonsoftJsonVersion
branch
from
2add553
to
eb50688
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug
Fixes: NuGet/Home#8108
Regression: No
Fix
Details: MSBuild target to run after restore to ensure that resolved version of Newtonsoft.Json matches the version in our
config.propsfile.I had to add a bunch of
PackageReferenceswithNoWarn="NU1605". If NuGet/Home#5740 gets implemented, many of these may no longer be needed.Testing/Validation
Tests Added: No
Reason for not adding tests: no product changes,
Validation: run build.ps1