Add hack to build VS15 experimental instance #2564
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PatoBeltran
requested review from
dominoFire,
nkolev92,
zivkan,
jainaashish and
heng-liu
nkolev92
approved these changes
Dec 13, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug
In 1d25f30#diff-e3360b39dbc9487df71573c870a8efccL57, a hack for making experimental instance buildable in VS14 was removed, we were not aware that this hack was also helping us build experimental instances in VS15.
If we remove this we get an error when trying to build our VSIX inside VS and run an experimental instance (dotnet/sdk#433)... This PR just adds the hack back to be able to use VS15 with experimental instance until we understand more about the reasons we need this for.