Nuget.exe list delisted option is not propagated correctly in certain cases for V2Feeds, closes #4334 #1136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nkolev92
changed the title
emgarten
reviewed
Jan 19, 2017
| } | ||
| } | ||
|
|
||
| Assert.True(ExpectedCount == ActualCount, "Expected was " + ExpectedCount + " but actual was " + ActualCount); |
There was a problem hiding this comment.
Use Assert.Equal to get exactly this 😄
emgarten
reviewed
Jan 19, 2017
| } | ||
| } | ||
|
|
||
| Assert.True(ExpectedCount == ActualCount, "Expected was " + ExpectedCount + " but actual was " + ActualCount); |
There was a problem hiding this comment.
It could be easier to debug in the future if you verified the names that should be there also, typically this helps in tests. But this should cover everything.
emgarten
approved these changes
Jan 19, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This closes NuGet/Home#4334
In some cases the "IncludeDelisted" option is not propagated fully.
When we call nuget.exe list -source SomeSource -IncludeDelisted
The IncludeDelisted option value is not included in the filter construction, which means it'll default to false.
I have fixed this and added some extra tests for this scenario.
\cc
@mishra14 @rohit21agrawal @alpaix @emgarten @zhili1208 @jainaashish