VsPackageInstallerServices should not post ProjectNotNominatedExcepti…

…on faults

src/NuGet.Clients/NuGet.VisualStudio.Implementation/Extensibility/VsPackageInstallerServices.cs

@@ -16,6 +16,7 @@
 using NuGet.Configuration;
 using NuGet.PackageManagement;
 using NuGet.PackageManagement.VisualStudio;
+using NuGet.PackageManagement.VisualStudio.Exceptions;
 using NuGet.Packaging;
 using NuGet.Packaging.PackageExtraction;
 using NuGet.Packaging.Signing;
@@ -126,6 +127,10 @@ public IEnumerable<IVsPackageMetadata> GetInstalledPackages()
                         return packages;
                     });
             }
+            catch (ProjectNotNominatedException)
+            {
+                throw;
+            }
             catch (Exception exception)
             {
                 _telemetryProvider.PostFault(exception, typeof(VsPackageInstallerServices).FullName);
@@ -266,6 +271,10 @@ public IEnumerable<IVsPackageMetadata> GetInstalledPackages(Project project)
                         return packages;
                     });
             }
+            catch (ProjectNotNominatedException)
+            {
+                throw;
+            }
             catch (Exception exception)
             {
                 _telemetryProvider.PostFault(exception, typeof(VsPackageInstallerServices).FullName);
@@ -351,6 +360,10 @@ private bool IsPackageInstalled(Project project, string packageId, NuGetVersion
 
                     return PackageServiceUtilities.IsPackageInList(installedPackageReferences, packageId, nugetVersion);
                 }
+                catch (ProjectNotNominatedException)
+                {
+                    throw;
+                }
                 catch (Exception exception)
                 {
                     await _telemetryProvider.PostFaultAsync(exception, typeof(VsPackageInstallerServices).FullName);

src/NuGet.Clients/NuGet.VisualStudio/Extensibility/IVsPackageInstallerServices.cs

@@ -31,6 +31,8 @@ public interface IVsPackageInstallerServices
         /// <param name="project">The project to check for NuGet package.</param>
         /// <param name="id">The id of the package to check.</param>
         /// <returns><c>true</c> if the package is install. <c>false</c> otherwise.</returns>
+        /// <exception cref="InvalidOperationException">A "project not nominated" exception will be thrown if the project is asynchronous and the project system has not yet told NuGet about the project.
+        /// You can use <see cref="IVsNuGetProjectUpdateEvents"/> or Microsoft.VisualStudio.OperationProgress to be notified when the project is ready.</exception>
         [Obsolete("This method can cause UI delays if called on the UI thread. Use INuGetProjectService.GetInstalledPackagesAsync in the NuGet.VisualStudio.Contracts package instead, and check the specific package you're interested in")]
         bool IsPackageInstalled(Project project, string id);
 
@@ -41,6 +43,8 @@ public interface IVsPackageInstallerServices
         /// <param name="id">The id of the package to check.</param>
         /// <param name="version">The version of the package to check.</param>
         /// <returns><c>true</c> if the package is install. <c>false</c> otherwise.</returns>
+        /// <exception cref="InvalidOperationException">A "project not nominated" exception will be thrown if the project is asynchronous and the project system has not yet told NuGet about the project.
+        /// You can use <see cref="IVsNuGetProjectUpdateEvents"/> or Microsoft.VisualStudio.OperationProgress to be notified when the project is ready.</exception>
         [Obsolete("This method can cause UI delays if called on the UI thread. Use INuGetProjectService.GetInstalledPackagesAsync in the NuGet.VisualStudio.Contracts package instead, and check the specific package you're interested in")]
         bool IsPackageInstalled(Project project, string id, SemanticVersion version);
 
@@ -56,13 +60,17 @@ public interface IVsPackageInstallerServices
         /// when client project compiles against this assembly, the compiler would attempt to bind against
         /// the other overload which accepts SemanticVersion and would require client project to reference NuGet.Core.
         /// </remarks>
+        /// <exception cref="InvalidOperationException">A "project not nominated" exception will be thrown if the project is asynchronous and the project system has not yet told NuGet about the project.
+        /// You can use <see cref="IVsNuGetProjectUpdateEvents"/> or Microsoft.VisualStudio.OperationProgress to be notified when the project is ready.</exception>
         [Obsolete("This method can cause UI delays if called on the UI thread. Use INuGetProjectService.GetInstalledPackagesAsync in the NuGet.VisualStudio.Contracts package instead, and check the specific package you're interested in")]
         bool IsPackageInstalledEx(Project project, string id, string versionString);
 
         /// <summary>
         /// Get the list of NuGet packages installed in the specified project.
         /// </summary>
         /// <param name="project">The project to get NuGet packages from.</param>
+        /// <exception cref="InvalidOperationException">A "project not nominated" exception will be thrown if the project is asynchronous and the project system has not yet told NuGet about the project.
+        /// You can use <see cref="IVsNuGetProjectUpdateEvents"/> or Microsoft.VisualStudio.OperationProgress to be notified when the project is ready.</exception>
         [Obsolete("This method can cause UI delays if called on the UI thread. Use INuGetProjectService.GetInstalledPackagesAsync in the NuGet.VisualStudio.Contracts package instead")]
         IEnumerable<IVsPackageMetadata> GetInstalledPackages(Project project);
     }

src/NuGet.Core/NuGet.Protocol/HttpSource/HttpSourceAuthenticationHandler.cs

@@ -25,7 +25,9 @@ public class HttpSourceAuthenticationHandler : DelegatingHandler
         private readonly HttpClientHandler _clientHandler;
         private readonly ICredentialService _credentialService;
 
+#pragma warning disable CA2213 // Disposable fields should be disposed
         private readonly SemaphoreSlim _httpClientLock = new SemaphoreSlim(1, 1);
+#pragma warning restore CA2213 // Disposable fields should be disposed
         private Dictionary<string, AmbientAuthenticationState> _authStates = new Dictionary<string, AmbientAuthenticationState>();
         private HttpSourceCredentials _credentials;