Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add p1 Issue query and separate issues by repo #56

Merged
merged 1 commit into from
Sep 30, 2021

Conversation

donnie-msft
Copy link
Contributor

  • Separate "all" vars by repo.
  • Add queries for Priority1 Open issues by repo
  • Write a JSON file with those P1 issues for export.

State = ItemState.Open,
Labels = queryLabels
};
var issuesForMilestone = await client.Search.SearchIssues(request);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SearchIssues is a workaround for the other api we were using.
Had weird JSON deserialization issues, and found this bug: octokit/octokit.net#1762

@@ -9,8 +11,10 @@ namespace GithubIssueTagger
public class Program
{
private static IList<Issue> _unprocessedIssues;
private static IReadOnlyList<Label> _allLabels;
private static IEnumerable<Issue> _allIssues;
private static IReadOnlyList<Label> _allHomeLabels;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't want to add more to work for, but these statics make me cringe :)

It'd be neater if you were using return values/passed collections etc.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change really has nothing to do with the statics, but I simply had to split them into 2 collections. Someone can separately PR refactoring if we think that's needed.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, more of a general comment.

I might do the refactoring opportunistically if you don't mind.

@donnie-msft donnie-msft merged commit 03cb6d3 into main Sep 30, 2021
@nkolev92 nkolev92 deleted the dev-donnie-msft-githubP1IssueQuery branch September 30, 2021 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants