Fix crashes if the query has undefined as value #707
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
radex
requested changes
Jun 1, 2020
| @@ -30,7 +30,7 @@ const encodeWhereDescription: WhereDescription => Matcher<*> = description => ra | |||
| } else if (compRight.column) { | |||
| right = (rawRecord: Object)[compRight.column] | |||
| } else { | |||
| throw new Error('Invalid comparisonRight') | |||
| right = undefined | |||
There was a problem hiding this comment.
i'm ok with allowing undefined, but this is not the correct solution. compRight.value !== undefined ought to be modified so that it checks for a property's presence, and not value.
There was a problem hiding this comment.
Right. I will correct
There was a problem hiding this comment.
@leninlin Hey, you there? do you want to finish up this PR?
There was a problem hiding this comment.
Oh, sorry. I forgot. I will finish this.
|
please also add a CHANGELOG note |
|
Made redundant by #1198 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
For example, I have lines like these
noteIdmay beundefinedat some points in time. I understand that this is bad and I fixed it, but in this case I get an unpleasant crash.Fetching from the database itself works well with
undefined, but when you change any record in this table, the application dies. The action is in one place, but the error is thrown from another place. This moment is hard to find and debug.Therefore, I propose to do the same behavior for the fetch and for observe, removing the throwing error.
For example, in the sqlite adapter,
undefinedis set to null. And on observe, undefined == null // => true