-
Notifications
You must be signed in to change notification settings - Fork 614
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Encrypted SQLite DB for Android #597
Encrypted SQLite DB for Android #597
Conversation
…uest * features/encryption-for-android: should provide option to work without password as well -> tested and working
…db-pull-request * features/pull-request: should provide option to work without password as well -> tested and working cleanup fix cleanup adjusted bridge adjusted build-script adjusted for iOS password cleanup intermediate state
hi @afiller is there any update on this here? anything I could help with? right now it seems to be only a pending conflict res, but maybe there was some back channeling I'm not aware of :) |
@afiller any progress on this? |
@afiller Hey, good evening. I'm here to ask for some guidance if you're able to help. My project requires database encryption(late requisite, else I would not have used Watermelon) so i'm trying to port you patch to Watermelon 0.17.1. |
Closed in favor of #907 . Thank you for your work! |
Hi, as promised in #51 hereby I provide a pull request for encrypted databases on android. It's tested (ci:check and in a test project) and working. Nevertheless I want to address some things:
It works with or without password, but in all of the cases it's using another SQLite implementation for android. In my tests it works perfect, but I wanted to tell you.
The new library requires to be mentioned in the licenses, see https://www.zetetic.net/sqlcipher/open-source/
I did not change documentation at all. It's up to you where to mention this.
If none is given the DB is not encrypted. Quite easy and backwards compatible.
Feel free to change what you want. :) I hope it's a valuable contribution and I would look forward to be mentioned in the contributors section - but of course that's not a "must".
Best regards,
Andreas