Skip to content

Commit

Permalink
rename twinklefluff.js to twinklerollback.js
Browse files Browse the repository at this point in the history
fixes wikimedia-gadgets#1974

- Did an all repo, case sensitive search and replace of Twinkle.fluff -> Twinkle.rollback
- Did an all repo search for "fluff" and changed remaining results to "rollback"

IMPORTANT: requires modifying https://test.wikipedia.org/wiki/MediaWiki:Gadgets-definition and https://en.wikipedia.org/wiki/MediaWiki:Gadgets-definition

IMPORTANT: may also require creating/renaming "Module: rollback" tag in the GitHub issue tracker, so that the PR labeler doesn't break

Because of the gadget definition file changes, should be careful with this one. May want to do a deploy to testwiki before deploying to enwiki.

Note to self: I haven't manually tested this yet. Manually test it before merging.
  • Loading branch information
NovemLinguae committed Jun 22, 2024
1 parent 100cfbf commit 1bc5493
Show file tree
Hide file tree
Showing 10 changed files with 82 additions and 82 deletions.
4 changes: 2 additions & 2 deletions .github/labels.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,8 @@
- modules/twinkleconfig.js
"Module: diff":
- modules/twinklediff.js
"Module: fluff":
- modules/twinklefluff.js
"Module: rollback":
- modules/twinklerollback.js
"Module: prod":
- modules/twinkleprod.js
"Module: protect":
Expand Down
4 changes: 2 additions & 2 deletions DEVELOPER.md
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ Each Twinkle module and dependency lives on the wiki as a separate file. The lis
- `modules/twinklebatchdelete.js` → [MediaWiki:Gadget-twinklebatchdelete.js][]
- `modules/twinklebatchprotect.js` → [MediaWiki:Gadget-twinklebatchprotect.js][]
- `modules/twinkleconfig.js` → [MediaWiki:Gadget-twinkleconfig.js][]
- `modules/twinklefluff.js` → [MediaWiki:Gadget-twinklefluff.js][]
- `modules/twinklerollback.js` → [MediaWiki:Gadget-twinklerollback.js][]
- `modules/twinkleprotect.js` → [MediaWiki:Gadget-twinkleprotect.js][]
- `modules/twinklearv.js` → [MediaWiki:Gadget-twinklearv.js][]
- `modules/friendlytalkback.js` → [MediaWiki:Gadget-friendlytalkback.js][]
Expand Down Expand Up @@ -120,7 +120,7 @@ The `--base` flag operates as a *prefix*; note the presence of the trailing `/`.
[MediaWiki:Gadget-twinklebatchdelete.js]: https://en.wikipedia.org/wiki/MediaWiki:Gadget-twinklebatchdelete.js
[MediaWiki:Gadget-twinklebatchprotect.js]: https://en.wikipedia.org/wiki/MediaWiki:Gadget-twinklebatchprotect.js
[MediaWiki:Gadget-twinkleconfig.js]: https://en.wikipedia.org/wiki/MediaWiki:Gadget-twinkleconfig.js
[MediaWiki:Gadget-twinklefluff.js]: https://en.wikipedia.org/wiki/MediaWiki:Gadget-twinklefluff.js
[MediaWiki:Gadget-twinklerollback.js]: https://en.wikipedia.org/wiki/MediaWiki:Gadget-twinklerollback.js
[MediaWiki:Gadget-twinkleprotect.js]: https://en.wikipedia.org/wiki/MediaWiki:Gadget-twinkleprotect.js
[MediaWiki:Gadget-twinklearv.js]: https://en.wikipedia.org/wiki/MediaWiki:Gadget-twinklearv.js
[MediaWiki:Gadget-friendlytalkback.js]: https://en.wikipedia.org/wiki/MediaWiki:Gadget-friendlytalkback.js
Expand Down
2 changes: 1 addition & 1 deletion gadget.txt
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
* Twinkle[ResourceLoader|dependencies=ext.gadget.morebits,ext.gadget.select2,mediawiki.api,mediawiki.language|rights=autoconfirmed|type=general|peers=Twinkle-pagestyles|requiresES6]|Twinkle.js|Twinkle.css|twinklearv.js|twinklewarn.js|twinkleblock.js|friendlywelcome.js|friendlyshared.js|friendlytalkback.js|twinklespeedy.js|twinkleprod.js|twinklexfd.js|twinkleimage.js|twinkleprotect.js|friendlytag.js|twinklediff.js|twinkleunlink.js|twinklefluff.js|twinkledeprod.js|twinklebatchdelete.js|twinklebatchprotect.js|twinklebatchundelete.js|twinkleconfig.js
* Twinkle[ResourceLoader|dependencies=ext.gadget.morebits,ext.gadget.select2,mediawiki.api,mediawiki.language|rights=autoconfirmed|type=general|peers=Twinkle-pagestyles|requiresES6]|Twinkle.js|Twinkle.css|twinklearv.js|twinklewarn.js|twinkleblock.js|friendlywelcome.js|friendlyshared.js|friendlytalkback.js|twinklespeedy.js|twinkleprod.js|twinklexfd.js|twinkleimage.js|twinkleprotect.js|friendlytag.js|twinklediff.js|twinkleunlink.js|twinklerollback.js|twinkledeprod.js|twinklebatchdelete.js|twinklebatchprotect.js|twinklebatchundelete.js|twinkleconfig.js
* morebits[ResourceLoader|dependencies=mediawiki.user,mediawiki.util,mediawiki.Title,jquery.ui|hidden|requiresES6]|morebits.js|morebits.css
* Twinkle-pagestyles[hidden|skins=vector,vector-2022]|Twinkle-pagestyles.css
* select2[ResourceLoader|hidden]|select2.min.js|select2.min.css
8 changes: 4 additions & 4 deletions modules/twinkleconfig.js
Original file line number Diff line number Diff line change
Expand Up @@ -172,7 +172,7 @@ Twinkle.config.sections = [
label: 'Turn off the selected Twinkle modules',
helptip: 'Anything you select here will NOT be available for use, so act with care. Uncheck to reactivate.',
type: 'set',
setValues: { arv: 'ARV', warn: 'Warn', welcome: 'Welcome', shared: 'Shared IP', talkback: 'Talkback', speedy: 'CSD', prod: 'PROD', xfd: 'XfD', image: 'Image (DI)', protect: 'Protect (RPP)', tag: 'Tag', diff: 'Diff', unlink: 'Unlink', fluff: 'Revert and rollback' }
setValues: { arv: 'ARV', warn: 'Warn', welcome: 'Welcome', shared: 'Shared IP', talkback: 'Talkback', speedy: 'CSD', prod: 'PROD', xfd: 'XfD', image: 'Image (DI)', protect: 'Protect (RPP)', tag: 'Tag', diff: 'Diff', unlink: 'Unlink', rollback: 'Revert and rollback' }
},

// Twinkle.config.disabledSysopModules (array)
Expand Down Expand Up @@ -338,8 +338,8 @@ Twinkle.config.sections = [
},

{
title: 'Revert and rollback', // twinklefluff module
module: 'fluff',
title: 'Revert and rollback', // twinklerollback module
module: 'rollback',
preferences: [
// TwinkleConfig.autoMenuAfterRollback (bool)
// Option to automatically open the warning menu if the user talk page is opened post-reversion
Expand Down Expand Up @@ -952,7 +952,7 @@ Twinkle.config.sections = [
name: 'portletNext',
type: 'string'
},
// twinklefluff.js: defines how many revision to query maximum, maximum possible is 50, default is 50
// twinklerollback.js: defines how many revision to query maximum, maximum possible is 50, default is 50
{
name: 'revertMaxRevisions',
type: 'integer'
Expand Down
Loading

0 comments on commit 1bc5493

Please sign in to comment.