Skip to content
This repository has been archived by the owner on Jan 10, 2024. It is now read-only.

Scrolling not working on iOS 12.1.1 #16

Closed
singhsaban opened this issue Dec 14, 2018 · 5 comments
Closed

Scrolling not working on iOS 12.1.1 #16

singhsaban opened this issue Dec 14, 2018 · 5 comments

Comments

@singhsaban
Copy link

Hi,
The scrolling issue has re-appeared for iOS 12.1.1 #8 .

I noticed that scrolling has been turned off in nativescript-webview-ext/webview-ext.uiwebview.js.

uiWebView.scrollView.scrollEnabled = false;

And setting this to true does fix the issue. Let me know if this is a valid fix for the issue. I could send in a PR.

Thanks.

@m-abs
Copy link
Contributor

m-abs commented Dec 17, 2018

Hmm, that's odd.

UIWebview shouldn't be used on iOS 12.x.

@m-abs
Copy link
Contributor

m-abs commented Dec 17, 2018

Could you provide an example project for this issue?

@singhsaban
Copy link
Author

Hi @m-abs ,
I've created a demo nativescript-vue project https://github.com/singhsaban/webview-ext-demo. To replicate the issue on iOS 12.1.1 make the following true in the webview-ext package itself.

uiWebView.scrollView.scrollEnabled = false;

@m-abs
Copy link
Contributor

m-abs commented Dec 19, 2018

Hi thanks,

I've removed that line and fixed the test for UIWebView or WKWebView.
Only older versions of iOS should use UIWebView but 12.1.1 resulted in a NaN so the check failed.

Try updating to latest version.

@singhsaban
Copy link
Author

Thanks @m-abs for the fix.

@m-abs m-abs closed this as completed Dec 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants