HotFix - 2.1.2 #179
Merged
HotFix - 2.1.2 #179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
supercid
commented
Jun 28, 2018
•
supercid
commented
- Fix SKU Variations For Single Products
- Add Variant Configuration Group Options Into Custom Attributes
- Fix issue when updating the plugin could not create database column for cart restore hash
- Fix missing category tagging in category listing page
fairlane
suggested changes
Jul 2, 2018
Components/Helper/CustomFields.php
Outdated
| foreach ($configurator as $config) { | ||
| /** @var Option $config */ | ||
| if (!$config instanceof Option | ||
| && $config->getGroup() === null |
There was a problem hiding this comment.
Should the operator be OR?
if (!$config instanceof Option
|| $config->getGroup() === null)
CHANGELOG.md
Outdated
| @@ -2,6 +2,12 @@ | |||
| All notable changes to this project will be documented in this file. | |||
| This project adheres to [Semantic Versioning](http://semver.org/). | |||
|
|
|||
| ## [2.1.2] | |||
There was a problem hiding this comment.
- I wouldn't use came case in change log
- Also check the changes linking (the links are defined at the end of the change log file)
fairlane
approved these changes
Jul 3, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.