Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tagging providers and Hyvä compatibility #871

Draft
wants to merge 17 commits into
base: develop
Choose a base branch
from
Draft

Tagging providers and Hyvä compatibility #871

wants to merge 17 commits into from

Conversation

supercid
Copy link
Contributor

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Documentation:

Checklist:

  • My code follows the code style of this project.
  • I have updated the documentation accordingly.
  • All new and existing tests passed.
  • I have assigned the correct milestone or created one if non-existent.
  • I have correctly labeled this pull request.
  • I have linked the corresponding issue in this description.
  • I have updated the corresponding Jira ticket.
  • I have requested a review from at least 2 reviewers
  • I have checked the base branch of this pull request
  • I have checked my code for any possible security vulnerabilities

@supercid supercid changed the title Add Hyva compatibility Tagging providers and Hyvä compatibility Feb 27, 2025
@supercid
Fix jsonEscape warning
af88bca
@supercid
unknown is not a valid page type on tagging providers
c764c42
@supercid
Fix for require on hyva
ce55373
@supercid
Safeguards fo requireJS and hyva
2bb6f4a 
Now we set all the functions on the global scope and mock a define() to avoid “not defined error” when in hyvä
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@supercid