Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace Zend_Uri_Http with Laminas\Uri #843

Merged
merged 1 commit into from
Jan 22, 2024
Merged

Replace Zend_Uri_Http with Laminas\Uri #843

merged 1 commit into from
Jan 22, 2024

Conversation

piotrkwiecinski
Copy link
Contributor

Description

Replace Zend_Uri_Http with equivalent from Laminas

Related Issue

#842

Motivation and Context

Fixes exception in Frontend Cart controller.

Checklist:

  • My code follows the code style of this project.
  • I have updated the documentation accordingly.
  • All new and existing tests passed.
  • I have assigned the correct milestone or created one if non-existent.
  • I have correctly labeled this pull request.
  • I have linked the corresponding issue in this description.
  • I have updated the corresponding Jira ticket.
  • I have requested a review from at least 2 reviewers
  • I have checked the base branch of this pull request
  • I have checked my code for any possible security vulnerabilities

@supercid supercid merged commit cbe6a08 into Nosto:develop Jan 22, 2024
@supercid
Copy link
Member

@piotrkwiecinski
Thanks for the update! We'll include this in out next release 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@supercid supercid supercid approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@piotrkwiecinski @supercid