Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restore delete queue to handle the product deletion #827

Merged
merged 7 commits into from
Jun 22, 2023
Merged

Restore delete queue to handle the product deletion #827

merged 7 commits into from
Jun 22, 2023

Conversation

phonglynosto
Copy link
Contributor

Restore delete queue to handle the product deletion

Description

This commit will revert the commit 99293cf and make some modification to handle the product deletion

Related Issue

Motivation and Context

How Has This Been Tested?

Documentation:

Checklist:

  • My code follows the code style of this project.
  • I have updated the documentation accordingly.
  • All new and existing tests passed.
  • I have assigned the correct milestone or created one if non-existent.
  • I have correctly labeled this pull request.
  • I have linked the corresponding issue in this description.
  • I have updated the corresponding Jira ticket.
  • I have requested a review from at least 2 reviewers
  • I have checked the base branch of this pull request
  • I have checked my code for any possible security vulnerabilities

@phonglynosto
Revert "Delete delete queue"
f1fee82 
This reverts commit 99293cf.
@phonglynosto
Additional fix while handling product deletion
1cb2445 
1. Bump version
2. Edit changelog
3. Add logic to prevent update child product when delete in case
the ProductIndexer is on Schedule mode
@phonglynosto
Merge remote-tracking branch 'origin/master' into hotfix/handle-delet…
f0b8e3d 
…ed-product
@phonglynosto
Use php-sdk 6.2.2 which restore delete operation
c0c8a33
supercid
supercid suggested changes Jun 13, 2023
View reviewed changes
@phonglynosto
Refactor
5ef2f79 
- Remove unused files
- When handle product deleting, we add id directly into update/delete queue instead of trigger indexer because in ProductIndexer it will not do anything if cannot find product based on id in collection, it just
handle the update operation
@phonglynosto phonglynosto force-pushed the hotfix/handle-deleted-product branch 5 times, most recently from 67fcd16 to 03f2f28 Compare June 15, 2023 09:50
@phonglynosto phonglynosto force-pushed the hotfix/handle-deleted-product branch from 03f2f28 to 4818344 Compare June 15, 2023 17:24
supercid
supercid approved these changes Jun 21, 2023
View reviewed changes
@phonglynosto phonglynosto merged commit ff81d06 into master Jun 22, 2023
@phonglynosto phonglynosto deleted the hotfix/handle-deleted-product branch June 22, 2023 09:46
@supercid supercid mentioned this pull request Jun 22, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@supercid supercid supercid approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@phonglynosto @supercid