Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collect category listing #820

Merged
merged 24 commits into from
Aug 29, 2023
Merged

Collect category listing #820

merged 24 commits into from
Aug 29, 2023

Conversation

dairbuirabass
Copy link
Contributor

Description

  • Update category tagging
  • Implement category export

Related Issue

Motivation and Context

How Has This Been Tested?

Documentation:

Checklist:

  • My code follows the code style of this project.
  • I have updated the documentation accordingly.
  • All new and existing tests passed.
  • I have assigned the correct milestone or created one if non-existent.
  • I have correctly labeled this pull request.
  • I have linked the corresponding issue in this description.
  • I have updated the corresponding Jira ticket.
  • I have requested a review from at least 2 reviewers
  • I have checked the base branch of this pull request
  • I have checked my code for any possible security vulnerabilities

@dairbuirabass dairbuirabass self-assigned this Feb 10, 2023
@phonglynosto
Copy link
Contributor

Screenshot 2023-06-09 at 15 12 47

Seem the category_ids and category_id are rendered in right way

@phonglynosto
Copy link
Contributor

Screenshot 2023-06-12 at 11 03 41 Screenshot 2023-06-12 at 11 03 53 Screenshot 2023-06-12 at 11 04 03 There is problem with playcart due to the parsing the query failed. Check picture for more information

Copy link
Contributor

@phonglynosto phonglynosto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test failed for updating category in playcart with Observer

@phonglynosto
Copy link
Contributor

Screenshot 2023-06-14 at 9 28 39

All the requires fields seem showing in the tagging and in the update category operation, those info will be passed to playcart

[
'available' => $this->category->isAvailable(),
'id' => $this->category->getId(),
'name' => $this->category->getTitle(),
'parentId' => $this->category->getParentId(),
'urlPath' => $this->category->getPath(),
]

Example:
Screenshot 2023-06-14 at 9 30 52

phonglynosto and others added 2 commits June 15, 2023 08:28
Use the right branch from php-sdk for now to prevent PHAN checking being failed. Need to fix before merge
@phonglynosto phonglynosto requested review from supercid and phonglynosto and removed request for phonglynosto June 16, 2023 08:36
@phonglynosto phonglynosto self-assigned this Jun 16, 2023
@supercid
Copy link
Member

Need to fix the conflicts

@phonglynosto phonglynosto dismissed their stale review June 27, 2023 12:11

I myself dismiss it

@phonglynosto phonglynosto force-pushed the feature/collect-category-listing branch from 5b78327 to d82dba6 Compare June 27, 2023 12:14
* @return AbstractCollection|CategoryCollection
* @throws NostoException
*/
public function buildExportCollection(Store $store, int $limit = 100, int $offset = 0)
Copy link
Member

@supercid supercid Aug 24, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@@ -41,7 +41,7 @@
"php": ">=7.4.0",
"magento/framework": ">=101.0.6|~104.0",
"ext-json": "*",
"nosto/php-sdk": "^6.2"
"nosto/php-sdk": "^7.1"
Copy link
Member

@supercid supercid Aug 24, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes category observer upsert query

@supercid supercid merged commit 646f4f3 into develop Aug 29, 2023
@supercid supercid deleted the feature/collect-category-listing branch August 29, 2023 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants