Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix/7.2.1 #819

Merged
merged 4 commits into from
Jan 11, 2023
Merged

Hotfix/7.2.1 #819

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
bf38875
Add store filter to category collection
dairbuirabass Jan 11, 2023
34589e8
bump version
dairbuirabass Jan 11, 2023
fe9bef3
Remove unnecessary statement
dairbuirabass Jan 11, 2023
e775b46
Phan suppress undeclared method
dairbuirabass Jan 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
All notable changes to this project will be documented in this file. This project adheres to Semantic Versioning.

### 7.2.1
* Add store filter to the DefaulCategoryService to generate categories for specific store

### 7.2.0
* Remove `nosto_product_sync` message queue consumer

Expand Down
3 changes: 2 additions & 1 deletion Model/Service/Product/Category/DefaultCategoryService.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,8 @@ public function __construct(
public function getCategories(Product $product, StoreInterface $store)
{
$categories = [];
foreach ($product->getCategoryCollection() as $category) {
/** @phan-suppress-next-line PhanUndeclaredMethod */
foreach ($product->getCategoryCollection()->setStore($store->getId()) as $category) {
$categoryString = $this->getCategory($category, $store);
if (!empty($categoryString)) {
$categories[] = $categoryString;
Expand Down
2 changes: 1 addition & 1 deletion composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"name": "nosto/module-nostotagging",
"description": "Increase your conversion rate and average order value by delivering your customers personalized product recommendations throughout their shopping journey.",
"type": "magento2-module",
"version": "7.2.0",
"version": "7.2.1",
"require-dev": {
"phpmd/phpmd": "^2.5",
"sebastian/phpcpd": "*",
Expand Down
2 changes: 1 addition & 1 deletion etc/module.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,5 +37,5 @@
<!--suppress XmlUnboundNsPrefix -->
<config xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
xsi:noNamespaceSchemaLocation="urn:magento:framework:Module/etc/module.xsd">
<module name="Nosto_Tagging" setup_version="7.2.0"/>
<module name="Nosto_Tagging" setup_version="7.2.1"/>
</config>