Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move currencies building process to a cronjob #773

Merged
merged 5 commits into from
Jun 7, 2022

Conversation

supercid
Copy link
Member

@supercid supercid commented Jun 7, 2022

Description

Removes the currency building from the settings observer, which run at every adminhtml login.

Related Issue

Not public

Motivation and Context

Merchants with a massive amount storeviews and currencies have trouble logging into admin if cache is cleared since we need to build the settings with all currencies for all storeviews. This offsets this operation to a cronjob, since we don't need to update currencies so often.

How Has This Been Tested?

Tested locally with:

bin/magento cron:install
bin/magento cron:run

Check on the database with:

SELECT job_code 
FROM cron_schedule 
WHERE job_code LIKE '%nosto%';
GROUP BY job_code

image

Documentation:

Nosto/wiki-docs#71

Checklist:

  • My code follows the code style of this project.
  • I have updated the documentation accordingly.
  • All new and existing tests passed.
  • I have assigned the correct milestone or created one if non-existent.
  • I have correctly labeled this pull request.
  • I have linked the corresponding issue in this description.
  • I have updated the corresponding Jira ticket.
  • I have requested a review from at least 2 reviewers
  • I have checked the base branch of this pull request
  • I have checked my code for any possible security vulnerabilities

@supercid supercid self-assigned this Jun 7, 2022
@supercid supercid modified the milestones: 7.0.0, 6.1.0 Jun 7, 2022
@supercid supercid marked this pull request as draft June 7, 2022 11:33
Cron/CurrenciesCron.php Outdated Show resolved Hide resolved
@supercid supercid marked this pull request as ready for review June 7, 2022 12:14
@supercid supercid merged commit 71998b2 into develop Jun 7, 2022
@supercid supercid deleted the feature/currency-builder-cron branch June 7, 2022 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants