Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/2.4.4 compatibility #766

Merged
merged 78 commits into from
May 3, 2022
Merged

Feature/2.4.4 compatibility #766

merged 78 commits into from
May 3, 2022

Conversation

supercid
Copy link
Member

@supercid supercid commented Mar 21, 2022

Description

  • Update PHP SDK
  • Bump PHP min version to 7.4
  • Suppress PHP 8.1 inheritance warning (since 7.4 does not have typehint return for mixed, which is needed)
  • Little bit more strict types
  • Better types in general

Related Issue

Not public

Motivation and Context

Magento 2.4.4 came with significant changes to how we handle the data schema, requiring removal of PHP based schema to XML.

How Has This Been Tested?

Tested locally with a brand new docker image for Magento 2.4.4 and PHP 8.1
You can test by using https://github.com/supercid/magento-docker-bin

Tested in plugintest at https://magento244.plugintest.nos.to/

Documentation:

No updates needed

Checklist:

  • My code follows the code style of this project.
  • I have updated the documentation accordingly.
  • All new and existing tests passed.
  • I have assigned the correct milestone or created one if non-existent.
  • I have correctly labeled this pull request.
  • I have linked the corresponding issue in this description.
  • I have updated the corresponding Jira ticket.
  • I have requested a review from at least 2 reviewers
  • I have checked the base branch of this pull request
  • I have checked my code for any possible security vulnerabilities

@dairbuirabass dairbuirabass marked this pull request as ready for review April 19, 2022 07:09
Helper/Price.php Outdated Show resolved Hide resolved
compile.sh Outdated Show resolved Hide resolved
@dairbuirabass dairbuirabass self-requested a review May 3, 2022 08:20
@supercid supercid merged commit 3dee14d into develop May 3, 2022
@supercid supercid deleted the feature/2.4.4-compatibility branch May 3, 2022 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants