Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete Dockerfile #757

Merged
merged 8 commits into from
Jan 14, 2022
Merged

Delete Dockerfile #757

merged 8 commits into from
Jan 14, 2022

Conversation

dairbuirabass
Copy link
Contributor

Description

Remove Dockerfile

Related Issue

Motivation and Context

Dockerfile not needed

How Has This Been Tested?

Documentation:

Checklist:

  • My code follows the code style of this project.
  • I have updated the documentation accordingly.
  • All new and existing tests passed.
  • I have assigned the correct milestone or created one if non-existent.
  • I have correctly labeled this pull request.
  • I have linked the corresponding issue in this description.
  • I have updated the corresponding Jira ticket.
  • I have requested a review from at least 2 reviewers
  • I have checked the base branch of this pull request
  • I have checked my code for any possible security vulnerabilities

@@ -73,19 +73,6 @@ jobs:
extensions: ast, bcmath, gd
coverage: none

#https://github.com/actions/cache/blob/master/examples.md#php---composer
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this deleted? Be careful when deleting steps from the actions

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made those changes to test if it is causing the inspection runs, removed now. Ready for review @olsi-qose

@dairbuirabass dairbuirabass merged commit c2e0588 into develop Jan 14, 2022
@dairbuirabass dairbuirabass deleted the feature/delete-dockerfile branch January 14, 2022 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants