Update phan/phan and drenso/phan-extensions to latest #756
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mridang
reviewed
Nov 25, 2021
phan.php
Outdated
| @@ -82,6 +82,10 @@ | |||
| ], | |||
| 'suppress_issue_types' => [ | |||
| 'PhanParamSignatureMismatch', | |||
| 'PhanTypeMismatchReturn', | |||
There was a problem hiding this comment.
Let's not add more suppressions. I would rather make the fixes. If you are unsure on how to create stubs - let me know.
There was a problem hiding this comment.
Removed suppressions
mridang
approved these changes
Nov 25, 2021
dairbuirabass
commented
Nov 25, 2021
| $accountOwner->setFirstName(null); | ||
| $accountOwner->setLastName(null); | ||
| $accountOwner->setFirstName(''); | ||
| $accountOwner->setLastName(''); |
There was a problem hiding this comment.
@olsi-qose is it ok to change from null to empty string here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update phan/phan to latest (5.3.0) and drenso/phan-extensions to latest (3.5.1)
Related Issue
Motivation and Context
Keeping dev packages up to date
How Has This Been Tested?
Locally
Documentation:
Checklist: