Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix fetching price for configurable product from wrong store #703

Merged
merged 3 commits into from
Aug 20, 2020

Conversation

fairlane
Copy link
Contributor

@fairlane fairlane commented Aug 19, 2020

Description

Change the product data reloading to use correct store / website.

Related Issue

Closes #702

Motivation and Context

Wrong prices are sent to Nosto for configurable products when multiple base currencies are used and product prices are configured to be displayed including taxes.

How Has This Been Tested?

Tested locally with multiple websites and different base currencies.

Checklist:

  • My code follows the code style of this project.
  • I have updated the documentation accordingly.
  • All new and existing tests passed.
  • I have assigned the correct milestone or created one if non-existent.
  • I have correctly labeled this pull request.
  • I have linked the corresponding issue in this description.
  • I have updated the corresponding Jira ticket.
  • I have requested a review from at least 2 reviewers
  • I have checked the base branch of this pull request
  • I have checked my code for any possible security vulnerabilities

@fairlane fairlane added the bug label Aug 19, 2020
@fairlane fairlane added this to the 5.0.4 milestone Aug 19, 2020
@fairlane fairlane requested review from supercid and olsi-qose August 19, 2020 10:56
@fairlane fairlane self-assigned this Aug 19, 2020
@fairlane fairlane merged commit b21a126 into master Aug 20, 2020
@fairlane fairlane deleted the hotfix/5.0.4 branch August 20, 2020 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants