Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hotfix 5.0.1 #692

Merged
merged 2 commits into from
Jun 12, 2020
Merged

Hotfix 5.0.1 #692

merged 2 commits into from
Jun 12, 2020

Conversation

fairlane
Copy link
Contributor

@fairlane fairlane commented Jun 12, 2020 •
edited
Loading

Description

Fix an issue with configurable product prices being zero when taxes are included in display prices.

Related Issue

#691

Motivation and Context

Self-explanatory

How Has This Been Tested?

Tested locally with setting the prices to be displayed with and without taxes.

Checklist:

  • My code follows the code style of this project.
  • I have updated the documentation accordingly.
  • All new and existing tests passed.
  • I have assigned the correct milestone or created one if non-existent.
  • I have correctly labeled this pull request.
  • I have linked the corresponding issue in this description.
  • I have updated the corresponding Jira ticket.
  • I have checked the base branch of this pull request
  • I have checked my code for any possible security vulnerabilities

@fairlane fairlane added the bug label Jun 12, 2020
@fairlane fairlane added this to the 5.0.1 milestone Jun 12, 2020
@fairlane fairlane self-assigned this Jun 12, 2020
@fairlane fairlane requested a review from supercid June 12, 2020 06:11
@fairlane fairlane merged commit 93fac09 into master Jun 12, 2020
@fairlane fairlane deleted the hotfix/5.0.1 branch June 12, 2020 06:38
@fairlane fairlane mentioned this pull request Jun 12, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@supercid supercid supercid approved these changes

Assignees

@fairlane fairlane

Labels
bug
Projects
None yet
Milestone
5.0.1
Development

Successfully merging this pull request may close these issues.
2 participants
@fairlane @supercid