Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hotfix/4.0.9 #680

Merged
merged 5 commits into from
May 28, 2020
Merged

Hotfix/4.0.9 #680

merged 5 commits into from
May 28, 2020

Conversation

fairlane
Copy link
Contributor

@fairlane fairlane commented May 27, 2020 •
edited
Loading

Description

Add support for overriding configurable product price handling via MSI module.

Related Issue

#678

Motivation and Context

Configurable product prices are zero for Nosto product data when MSI is used without default stock source.

How Has This Been Tested?

Tested locally

Checklist:

  • My code follows the code style of this project.
  • I have updated the documentation accordingly.
  • All new and existing tests passed.
  • I have assigned the correct milestone or created one if non-existent.
  • I have correctly labeled this pull request.
  • I have linked the corresponding issue in this description.
  • I have updated the corresponding Jira ticket.
  • I have requested a review from at least 2 reviewers
  • I have checked the base branch of this pull request
  • I have checked my code for any possible security vulnerabilities

@fairlane fairlane added the bug label May 28, 2020
@fairlane fairlane self-assigned this May 28, 2020
@fairlane fairlane added this to the 4.0.9 milestone May 28, 2020
@fairlane fairlane linked an issue May 28, 2020 that may be closed by this pull request
Configurable product prices are null if default stock is not in use #678
Closed
6 tasks
@fairlane fairlane requested review from supercid and olsi-qose May 28, 2020 08:27
@fairlane fairlane marked this pull request as ready for review May 28, 2020 08:27
@fairlane fairlane merged commit 1b3cb10 into master May 28, 2020
@fairlane fairlane deleted the hotfix/4.0.9 branch May 28, 2020 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olsi-qose olsi-qose olsi-qose approved these changes

@supercid supercid supercid approved these changes

Assignees

@fairlane fairlane

Labels
bug
Projects
None yet
Milestone
4.0.9
Development

Successfully merging this pull request may close these issues.

Configurable product prices are null if default stock is not in use
3 participants
@fairlane @supercid @olsi-qose